Selvasundaram has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
Line 29:
Line 30: @Override
Line 31: @SuppressWarnings("unchecked")
Line 32: protected void executeQueryCommand() {
Line 33: Map<String, String> glusterServers = null;
You may initialize with empty hash map instead of null and avoid the else
section.
Map<String, String> glusterServers = new HashMap<String, String>()
Line 34: VDS upServer =
getClusterUtils().getUpServer(getParameters().getClusterId());
Line 35:
Line 36: if(upServer != null ) {
Line 37: VDSReturnValue returnValue =
getBackendInstance().RunVdsCommand(VDSCommandType.GlusterServersList,
--
To view, visit http://gerrit.ovirt.org/9314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I839589d239a3dec771fc9aad7a0ef8f8e1a195fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
