Allon Mureinik has posted comments on this change. Change subject: core: Quota refactor ......................................................................
Patch Set 9: Looks good to me, but someone else must approve (2 inline comments) See question inline .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java Line 96: AddVmTemplateInterface(220, ActionGroup.CONFIGURE_TEMPLATE_NETWORK, false, QuotaDependency.NONE), Line 97: RemoveVmTemplateInterface(221, ActionGroup.CONFIGURE_TEMPLATE_NETWORK, false, QuotaDependency.NONE), Line 98: UpdateVmTemplateInterface(222, ActionGroup.CONFIGURE_TEMPLATE_NETWORK, false, QuotaDependency.NONE), Line 99: // ImagesCommands Line 100: TryBackToSnapshot(204, QuotaDependency.NONE), This implies creating a new Active image - shouldn't it be storage quota-dependent? Line 101: RestoreFromSnapshot(205, QuotaDependency.STORAGE), Line 102: CreateAllSnapshotsFromVm(206, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.STORAGE), Line 103: CreateSnapshot(207, QuotaDependency.STORAGE), Line 104: CreateSnapshotFromTemplate(208, QuotaDependency.STORAGE), Line 108: RemoveAllVmImages(212, QuotaDependency.STORAGE), Line 109: AddImageFromScratch(213, QuotaDependency.STORAGE), Line 110: RemoveTemplateSnapshot(215, QuotaDependency.STORAGE), Line 111: RemoveAllVmTemplateImageTemplates(216, QuotaDependency.STORAGE), Line 112: TryBackToAllSnapshotsOfVm(223, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.NONE), same here Line 113: RestoreAllSnapshots(224, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.STORAGE), Line 114: MoveOrCopyImageGroup(225, QuotaDependency.STORAGE), Line 115: MoveOrCopyDisk(226, QuotaDependency.STORAGE), Line 116: RemoveSnapshotSingleDisk(227, QuotaDependency.STORAGE), -- To view, visit http://gerrit.ovirt.org/9180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I109ae8ae0191f46abaa1be21a7ecfebe50b9993f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
