Allon Mureinik has posted comments on this change. Change subject: core: Default disk aliases when reading OVFs ......................................................................
Patch Set 1: mkublin - the best approach would be to do this inside BuildDisks(), agreed. However, the problem is that I need the vm/template name to generate a good alias, and the name is only generated in BuildVirtualSystem(). I could change the order in OvfManager around, but this will also change the semantics of OvfWRITER (because they both share the IOvfBuilder interface, which I agree is disgusting). I'm not sure we'd want to change the WRITER's behavior here too, but I'm more than open to your input. -- To view, visit http://gerrit.ovirt.org/9308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38ad9c56f9b97e174807d3fcbe0b3e43355803ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
