Yair Zaslavsky has posted comments on this change. Change subject: core: [WIP] Remove global lock on SPM calls from engine side ......................................................................
Patch Set 1: (3 inline comments) Some comments on commit msg. Also, please attach the bug URL I sent you via email. (This comment is just for the commit msg, I am starting to review the code now) .................................................... Commit Message Line 5: CommitDate: 2012-11-18 13:35:44 +0200 Line 6: Line 7: core: [WIP] Remove global lock on SPM calls from engine side Line 8: Line 9: The following patch is removing a global lock from spm operation at engine side, s/is/intrdoduces Line 10: after applying a patch we can send call sto SPM simenteniously. Line 11: The reason for WIP is: Line 12: 1. Need to be perfromed additional tests Line 13: 2. Need to be added additional exception in order to improve user expirience Line 6: Line 7: core: [WIP] Remove global lock on SPM calls from engine side Line 8: Line 9: The following patch is removing a global lock from spm operation at engine side, Line 10: after applying a patch we can send call sto SPM simenteniously. s/a/the Line 11: The reason for WIP is: Line 12: 1. Need to be perfromed additional tests Line 13: 2. Need to be added additional exception in order to improve user expirience Line 14: 3. Should to be fixed syncronization issue at IsoDirectoryVDSCommand and DestroyPoolVDSCommand Line 10: after applying a patch we can send call sto SPM simenteniously. Line 11: The reason for WIP is: Line 12: 1. Need to be perfromed additional tests Line 13: 2. Need to be added additional exception in order to improve user expirience Line 14: 3. Should to be fixed syncronization issue at IsoDirectoryVDSCommand and DestroyPoolVDSCommand Need to perform, need to add, should fix Line 15: Line 16: Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278 -- To view, visit http://gerrit.ovirt.org/9298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
