Vered Volansky has uploaded a new change for review. Change subject: webadmin: NPE fix when adding a domain (#856583) ......................................................................
webadmin: NPE fix when adding a domain (#856583) When Trying to add a storage domain with a not-supported format there was an NPE causing a bad error message instead of the correct one. This was caused since the StorageModel in StorageListModel wasn't set to the selected item. It is now. Change-Id: I07cb27ce4c50410840032cdda06deb3b20a5aa8b Bug-Url: https://bugzilla.redhat.com/856583 Signed-off-by: Vered Volansky <vvola...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/9259/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java index 52410af..3c9a25b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java @@ -1425,6 +1425,7 @@ public void Executed(FrontendActionAsyncResult result) { StorageListModel storageListModel = (StorageListModel) result.getState(); StorageModel storageModel = (StorageModel) storageListModel.getWindow(); + storageListModel.storageModel = storageModel.getSelectedItem(); if (!result.getReturnValue().getSucceeded()) { storageListModel.OnFinish(storageListModel.context, false, storageListModel.storageModel); return; -- To view, visit http://gerrit.ovirt.org/9259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I07cb27ce4c50410840032cdda06deb3b20a5aa8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
