Yair Zaslavsky has posted comments on this change.

Change subject: core:Do not force fencing proxy to be ...(#876235)
......................................................................


Patch Set 4: (1 inline comment)

....................................................
Commit Message
Line 15: host that is in UP status in the host DC.
Line 16: This patch modified the algorithm of proxy finding to
Line 17: 1) Look for a Host in the problematic Host DC which is UP
Line 18: 2) If 1) fails, try to use any other Host in the same DC as a proxy
Line 19:    if this Host is non-operational with NETWORK_UNREACHABLE reason.
Missing here - not selecting host which is non-operational and with 
NETWORK_UNREACHABLE (you wrote it, but needs a bit rephrasing).
Line 20: 
Line 21: This is done because there is no connection between the Host status and
Line 22: its ability to carry out proxy commands (which can be done if Host has
Line 23: network connectivity) although we can assume that a Host that is in UP


--
To view, visit http://gerrit.ovirt.org/9251
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437e9b2bb0300f8d71cc8f0c50aaff1b253a63bb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to