Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new vdsm-bootstrap
package
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 562: -- Update with override section
Line 563:
------------------------------------------------------------------------------------
Line 564:
Line 565: select
fn_db_update_config_value('AutoRecoveryAllowedTypes','{\"storage
domains\":\"false\",\"hosts\":\"true\"}','general');
Line 566: select
fn_db_update_config_value('BootstrapMinimalVdsmVersion','4.9.6','general');
It is just for not performing bootstrap if lower than this version.
It was hardcoded in the vdsm-bootstrap, I moved it to here so admin can
configure it or engine can enforce what good for it.
Line 567: select fn_db_update_config_value('CertAlias','1','general');
Line 568: select fn_db_update_config_value('DBEngine','Postgres','general');
Line 569: select
fn_db_update_config_value('DebugSearchLogging','false','general');
Line 570: select fn_db_update_config_value('DefaultTimeZone','(GMT) GMT
Standard Time','general');
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 137: getVds().getvds_type() == VDSType.oVirtNode
Line 138: ) {
Line 139: log.infoFormat(
Line 140: "Before Installation {0},
Powerclient/oVirtNode case: setting status to installing",
Line 141: Thread.currentThread().getName()
OK... it was legacy...
Replaced with getVds().getvds_name()
Line 142: );
Line 143: if (parameters.getOverrideFirewall()) {
Line 144: log.warnFormat(
Line 145: "Installation of Host {0} will ignore
Firewall Override option, since it is not supported for Host type {1}",
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsBootstrap.java
Line 14: import java.text.SimpleDateFormat;
Line 15: import java.util.Calendar;
Line 16: import java.util.List;
Line 17: import java.util.TimeZone;
Line 18: import java.util.concurrent.Callable;
To create tick machine... I needed interface which can accept void method and
through an exception. I could have created my own...
Line 19: import javax.naming.TimeLimitExceededException;
Line 20:
Line 21: import org.apache.commons.lang.StringUtils;
Line 22:
Line 243:
Line 244: /**
Line 245: * Construct iptables to send.
Line 246: */
Line 247: private String _getIpTables() {
Please no, this is a good convention to differentiate interface from private.
This way it is totally clear that this is private when used.
Line 248: VDSGroup vdsGroup =
DbFacade.getInstance().getVdsGroupDao().get(
Line 249: _vds.getvds_group_id()
Line 250: );
Line 251:
--
To view, visit http://gerrit.ovirt.org/9175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If78c62601231f4729ca95da7653907b37856d672
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
