Michael Pasternak has posted comments on this change.
Change subject: restapi: Mapping of empty name in user object (#B861098)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
Line 23: model.setEmail(entity.getemail());
Line 24: model.setDepartment(entity.getdepartment());
Line 25: if (entity.getgroups() != null) {
Line 26: // string.split for an empty string returns an array of
size 1
Line 27: if (entity.getgroups().trim().length() > 0) {
why not adding this condition to clause at line 25?
Line 28: model.setGroups(new Groups());
Line 29: for (String name : entity.getgroups().split(",")) {
Line 30: Group group = new Group();
Line 31: group.setName(name);
--
To view, visit http://gerrit.ovirt.org/9138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1444e755797b101a216fd2e20537dd6e2aaefb33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
