Allon Mureinik has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager
......................................................................
Patch Set 23: I would prefer that you didn't submit this
(1 inline comment)
+1 on the QuotaManager code, but I think the changes to CommandBase don't
belong here.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 336:
Line 337: @SuppressWarnings({ "unchecked", "synthetic-access" })
Line 338: protected final void internalCompensate() {
Line 339: try {
Line 340: if (isQuotaDependant()) {
All the changes here should be part of the previous patch.
Line 341: rollBackQuota();
Line 342: }
Line 343: } catch (NullPointerException e) {
Line 344: log.debug("RollbackQuota: failed (may be because quota is
disabled)", e);
--
To view, visit http://gerrit.ovirt.org/8776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb100467a55b26e4219d1a2562da86b81ffdc032
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
