Alon Bar-Lev has posted comments on this change.

Change subject: utils: ssh: fixup activity detection
......................................................................


Patch Set 1:

We should reset soft timeout if we have any activity. The wasProgress() returns 
status and clears the counter. 

The problem in current code is that we have both stdin and stdout activities, 
only the wasProgress() of stdin was called, hence not resetting the stdout 
counter, then we think we had activity at next window...

--
To view, visit http://gerrit.ovirt.org/9169
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb63134b2829ae57c902f9d3c33f10c5311bcf76
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to