Allon Mureinik has posted comments on this change.
Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint()
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
see question inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
Line 85: client.setHardTimeout(timeout);
Line 86: client.setSoftTimeout(timeout);
Line 87: client.setHost(serverName, 22);
Line 88: client.connect();
Line 89: PublicKey serverKey = client.getServerKey();
This looks like a lot of repetetive code from GetFingerpringQuery- can't it be
reused somehow?
Line 90: if (serverKey == null) {
Line 91: throw new Exception("No server key");
Line 92: }
Line 93: fingerPrint =
OpenSSHUtils.getKeyFingerprintString(serverKey);
--
To view, visit http://gerrit.ovirt.org/9160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
