Alon Bar-Lev has posted comments on this change.
Change subject: registration: fix null pointer exception
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 479: break;
Line 480: }
Line 481: }
Line 482: } else {
Line 483: if (hostToRegister != null) {
Isn't it better to check if we have host by referencing its variable?
Line 484: log.debugFormat(
Line 485: "No Change required for VDS {0}. Since it has
the same unique Id",
Line 486: hostToRegister.getId());
Line 487: }
--
To view, visit http://gerrit.ovirt.org/9158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cdbedceec4ce3482b59ee625d20b7fdf4ccba9b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
