Michael Kublin has posted comments on this change.
Change subject: core: errors during preview of diskless snapshots
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Performance regression
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 142:
snapshotsManager.removeAllIllegalDisks(previousActiveSnapshotId,
getVm().getId());
Line 143: // if there are no images we can should restore the
config now so it'll be executed within the transaction.
Line 144: if (!images.isEmpty()) {
Line 145: getCompensationContext().stateChanged();
Line 146: } else {
By that change u introduced regression at performance, you introduced rpc call
inside of transaction. Fix these.
Line 147: restoreVmConfigFromSnapshot();
Line 148: }
Line 149: return null;
Line 150: }
--
To view, visit http://gerrit.ovirt.org/9128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8edc74bc34676f526dfd24d2f89eb60d8acf2e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
