Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
......................................................................
Patch Set 2: (1 inline comment)
Incorporated review comment.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeProfileInfoReturnForXmlRpc.java
Line 70: for (Object brickProfileObj : brickProfileDetails) {
Line 71: BrickProfileDetails brickProfileDetail = new
BrickProfileDetails();
Line 72: Map<String, Object> brickProfile = (Map<String, Object>)
brickProfileObj;
Line 73:
brickProfileDetail.setBrickId(GlusterCoreUtil.getBrickByQualifiedName(volume.getBricks(),
Line 74: (String) brickProfile.get(BRICK)).getId());
Added the null check before setting brick Id.
Line 75:
Line 76: List<StatsInfo> statsInfo = new ArrayList<StatsInfo>();
Line 77: statsInfo.add(getStatInfo((Map<String, Object>)
brickProfile.get(CUMULATIVE_STATS), CUMULATIVE_STATS));
Line 78: statsInfo.add(getStatInfo((Map<String, Object>)
brickProfile.get(INTERVAL_STATS), INTERVAL_STATS));
--
To view, visit http://gerrit.ovirt.org/8646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47eb168bd4bcd5f3297a7e89a5ef46e643ed73e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
