Kiril Nesenko has posted comments on this change. Change subject: backend: changing template1 encoding to utf8 ......................................................................
Patch Set 7: (1 inline comment) .................................................... File backend/manager/dbscripts/engine-db-install.sh Line 13: # the file /root/.pgpass must exsists (created by engine-setup) after this script finish, Line 14: # in order to access the db Line 15: Line 16: # GLOBALS Line 17: source ./dbfunctions.sh I am not sure its a correct place to put it here in #GLOBALS. also i think it will be better to use full path ? Line 18: HOST=`/bin/hostname` Line 19: SCRIPT_NAME="engine-db-install" Line 20: CUR_DATE=`date +"%Y_%m_%d_%H_%M_%S"` Line 21: -- To view, visit http://gerrit.ovirt.org/8936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib380cc82f4ef7f30b266d29cfa27707fcb5b3601 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
