Michael Pasternak has posted comments on this change.

Change subject: restapi: #872819 - RSDL Create Lun Disk params
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 320:           disk.shareable: xs:boolean
Line 321:           disk.propagate_errors: xs:boolean
Line 322:           disk.wipe_after_delete: xs:boolean
Line 323:           disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}
Line 324:         #the signature below is for direct-LUN disk, which doesn't 
require size, but requires the lun id, the lun type, and the lun 
connection-details.. 
white space
Line 325:       - mandatoryArguments: {disk.interface: 'xs:string', 
disk.format: 'xs:string', disk.lun_storage.type: 'xs:string',
Line 326:           disk.lun_storage.logical_unit--COLLECTION: 
{logical_unit.id: 'xs:string', logical_unit.address: 'xs:string', 
logical_unit.port: 'xs:int', logical_unit.target: 'xs:string'}}
Line 327:         optionalArguments:
Line 328:           disk.alias: xs:string


Line 637:           disk.shareable: xs:boolean
Line 638:           disk.propagate_errors: xs:boolean
Line 639:           disk.wipe_after_delete: xs:boolean
Line 640:           disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}
Line 641:         #the signature below is for direct-LUN disk, which doesn't 
require size, but requires the lun id, the lun type, and the lun 
connection-details.. 
white space
Line 642:       - mandatoryArguments: {disk.interface: 'xs:string', 
disk.format: 'xs:string', disk.lun_storage.type: 'xs:string',
Line 643:           disk.lun_storage.logical_unit--COLLECTION: 
{logical_unit.id: 'xs:string', logical_unit.address: 'xs:string', 
logical_unit.port: 'xs:int', logical_unit.target: 'xs:string'}}
Line 644:         optionalArguments:
Line 645:           disk.alias: xs:string


Line 647:           disk.bootable: xs:boolean
Line 648:           disk.shareable: xs:boolean
Line 649:           disk.propagate_errors: xs:boolean
Line 650:           disk.wipe_after_delete: xs:boolean
Line 651:           disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}          
white space
Line 652:     urlparams: {}
Line 653:     headers:
Line 654:       Content-Type: {value: application/xml|json, required: true}
Line 655:       Expect: {value: 201-created, required: false}


--
To view, visit http://gerrit.ovirt.org/9021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I653b68dce433aa831808b3ea8c5154be00439111
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to