Allon Mureinik has posted comments on this change.
Change subject: core: lsm - prevent moving a shareable disk
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
All in all, looks find.
Some minor issues, see inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
Line 77: if (vmsForDisk.size() == 0) {
Line 78: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_FLOATING_DISK_NOT_SUPPORTED);
Line 79: }
Line 80:
Line 81: if (getDiskImage().isShareable()) {
This check should be moved up before the access to VmDao - let's prevent this
additional DB access.
Line 82: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_SHAREABLE_DISK_NOT_SUPPORTED);
Line 83: }
Line 84:
Line 85: // Cache for future use
....................................................
Commit Message
Line 4: Commit: Daniel Erez <de...@redhat.com>
Line 5: CommitDate: 2012-11-05 10:45:24 +0200
Line 6:
Line 7: core: lsm - prevent moving a shareable disk
Line 8:
I'd add an explanation /why/ we're doing this.
Line 9: * Preventing shareable disk move.
Line 10: * Fixing error messages (shared -> shareable).
Line 11: * Fixing typo in error messages (opperation -> operation).
Line 12:
--
To view, visit http://gerrit.ovirt.org/9020
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd235a4c0634f246d7613e520af7f245ccdbc779
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
