Ofer Schreiber has posted comments on this change. Change subject: packaging: Updated VDC utilities to accept alternative binary ......................................................................
Patch Set 4: I would prefer that you didn't submit this (3 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 824: execRemoteSqlCommand(getDbUser(), getDbHostName(), getDbPort(), Line 825: basedefs.DB_POSTGRES, sqlQuery, True, Line 826: output_messages.ERR_DB_RENAME % (oldname, newname)) Line 827: Line 828: def getVDCOption(key, engineConfigBin=basedefs.FILE_RHEVM_CONFIG_BIN): RHEVM? Line 829: """ Line 830: Query vdc_option in db and return its value. Line 831: """ Line 832: Line 841: return out.split()[1] Line 842: else: Line 843: return None Line 844: Line 845: def updateVDCOption(key, value, maskList=[], keyType='text', engineConfigBin=basedefs.FILE_RHEVM_CONFIG_BIN, engineConfigExtended=basedefs.FILE_RHEVM_EXTENDED_CONF): RHEVM? Line 846: """ Line 847: Update vdc_option value in db Line 848: using rhevm-config Line 849: .................................................... File packaging/fedora/setup/engine-upgrade.py Line 822: deployDbAsyncTasks(dbName) Line 823: runningTasks = getRunningTasks(dbName) Line 824: compensations = getCompensations(dbName) Line 825: engineConfigBinary = basedefs.FILE_RHEVM_CONFIG_BIN Line 826: engineConfigExtended = basedefs.FILE_RHEVM_EXTENDED_CONF RHEVM? Line 827: origTimeout = 0 Line 828: Line 829: if runningTasks or compensations: Line 830: -- To view, visit http://gerrit.ovirt.org/8913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c009bffbcd956c64929050e9ebb806be006af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
