Eli Mesika has posted comments on this change. Change subject: core: Generate UUIDs from engine ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/dbscripts/insert_data.sql Line 7: v_cluster_id UUID; Line 8: v_id_0009 UUID; Line 9: BEGIN Line 10: v_id_0000 := '00000000-0000-0000-0000-000000000000'; Line 11: v_storage_pool_id := '5849B030-626E-47CB-AD90-3CE782D831B3'; Why this is changed , the UUID generation function should be available at the point that this script is called. Line 12: v_cluster_id := '99408929-82CF-4DC7-A532-9D998063FA95'; Line 13: v_id_0009 := '00000000-0000-0000-0000-000000000009'; Line 14: Line 15: .................................................... Commit Message Line 5: CommitDate: 2012-11-02 13:31:57 +0100 Line 6: Line 7: core: Generate UUIDs from engine Line 8: Line 9: We used to generate UUIDs used as primary keys of entities in the The entities that had used DB UUID generation are : Bookmark, Tag, Cluster, Host and VM Pools Line 10: database. This patch changes the engine so that it generates them Line 11: directly and passes them as parameters to the stored procedures as Line 12: needed. Line 13: Line 11: directly and passes them as parameters to the stored procedures as Line 12: needed. Line 13: Line 14: Note that some UUIDs can still be generated using the database function Line 15: uuid_generate_v1 during upgrades, as upgrade scripts haven't been during first installation as well Line 16: changed. Line 17: Line 18: Change-Id: Idecd3aa570017b4198243a9d3f9ebfdc7a777195 -- To view, visit http://gerrit.ovirt.org/8990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idecd3aa570017b4198243a9d3f9ebfdc7a777195 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches