Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Aligning buttons in AddBricks dialog
......................................................................
webadmin: Aligning buttons in AddBricks dialog
Add button is moved down and placed along side
brick directory.
Clear button is removed as there is only one
field which needs to be cleared.
Change-Id: I57a3893bbc0db14d23dee5f52d3f7e1f0b1098a3
Signed-off-by: Kanagaraj M <kmayi...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml
3 files changed, 3 insertions(+), 35 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/8996/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
index 679e8ca..87363ee 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
@@ -32,7 +32,6 @@
ListModel bricks;
private UICommand addBrickCommand;
- private UICommand clearBrickDetailsCommand;
private UICommand removeBricksCommand;
private UICommand removeAllBricksCommand;
@@ -57,7 +56,6 @@
setBricks(new ListModel());
setAddBrickCommand(new UICommand("AddBrick", this)); //$NON-NLS-1$
- setClearBrickDetailsCommand(new UICommand("ClearBrickDetails", this));
//$NON-NLS-1$
setRemoveBricksCommand(new UICommand("RemoveBricks", this));
//$NON-NLS-1$
setRemoveAllBricksCommand(new UICommand("RemoveAllBricks", this));
//$NON-NLS-1$
// getAddBrickCommand().setIsExecutionAllowed(false);
@@ -155,16 +153,6 @@
private void setRemoveBricksCommand(UICommand value)
{
removeBricksCommand = value;
- }
-
- public UICommand getClearBrickDetailsCommand()
- {
- return clearBrickDetailsCommand;
- }
-
- private void setClearBrickDetailsCommand(UICommand value)
- {
- clearBrickDetailsCommand = value;
}
public UICommand getRemoveAllBricksCommand()
@@ -601,10 +589,6 @@
if (command == getAddBrickCommand())
{
addBrick();
- }
- else if (command == getClearBrickDetailsCommand())
- {
- clearBrickDetails();
}
else if (command == getRemoveBricksCommand())
{
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
index e4ca45a..c76b5cc 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
@@ -80,10 +80,6 @@
UiCommandButton addBrickButton;
@UiField
- @WithElementId
- UiCommandButton clearButton;
-
- @UiField
@Ignore
@WithElementId
Label bricksHeader;
@@ -173,15 +169,6 @@
}
});
- clearButton.addClickHandler(new ClickHandler() {
-
- @Override
- public void onClick(ClickEvent event) {
- clearButton.getCommand().Execute();
- clearSelections();
- }
- });
-
removeBricksButton.addClickHandler(new ClickHandler() {
@@ -235,7 +222,6 @@
serverEditor.setLabel(constants.serverBricks());
exportDirEditor.setLabel(constants.brickDirectoryBricks());
addBrickButton.setLabel(constants.addBricksButtonLabel());
- clearButton.setLabel(constants.clearBricksButtonLabel());
removeBricksButton.setLabel(constants.removeBricksButtonLabel());
removeAllBricksButton.setLabel(constants.removeAllBricksButtonLabel());
moveBricksUpButton.setLabel(constants.moveBricksUpButtonLabel());
@@ -248,7 +234,6 @@
Driver.driver.edit(object);
addBrickButton.setCommand(object.getAddBrickCommand());
- clearButton.setCommand(object.getClearBrickDetailsCommand());
removeBricksButton.setCommand(object.getRemoveBricksCommand());
removeAllBricksButton.setCommand(object.getRemoveAllBricksCommand());
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml
index 324f3b6..6c277ca 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml
@@ -57,15 +57,14 @@
<g:Label ui:field="bricksHeader"
addStyleNames="{style.headerLabel}"/>
- <g:HorizontalPanel>
+ <g:HorizontalPanel
verticalAlignment="ALIGN_BOTTOM">
<g:VerticalPanel>
<e:ListModelListBoxEditor
ui:field="serverEditor"/>
<e:EntityModelTextBoxEditor
ui:field="exportDirEditor" />
</g:VerticalPanel>
- <g:VerticalPanel spacing="5">
+ <g:HorizontalPanel spacing="5">
<w:UiCommandButton
ui:field="addBrickButton" addStyleNames="{style.brickButton}"/>
- <w:UiCommandButton
ui:field="clearButton" addStyleNames="{style.brickButton}"/>
- </g:VerticalPanel>
+ </g:HorizontalPanel>
</g:HorizontalPanel>
<g:HorizontalPanel spacing="5"
verticalAlignment="ALIGN_MIDDLE">
--
To view, visit http://gerrit.ovirt.org/8996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57a3893bbc0db14d23dee5f52d3f7e1f0b1098a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
