Yair Zaslavsky has posted comments on this change.
Change subject: tools : rhevm-manage-domains location option no longer valid
(#871085)
......................................................................
Patch Set 1: (3 inline comments)
Correct, see more comments inside.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java
Line 53: private ManageDomainsDAOImpl daoImpl;
Line 54: private boolean reportAllErrors;
Line 55: private boolean addPermissions;
Line 56: private final static Logger log =
Logger.getLogger(ManageDomains.class);
Line 57: private final static String REMOTE_LOCATION = "remote";
This is not needed anymore.
Line 58:
Line 59: public enum Arguments {
Line 60: action,
Line 61: domain,
Line 67: report,
Line 68: interactive,
Line 69: addPermissions,
Line 70: provider,
Line 71: location
No need to include this at the arguments. I tried for example to pass a flag of
-foobar.
We don't handle all possible illegal arguments, but check for specific command
if one of the possible arguments may be illegal for it.
location is not need at all, so you can say in that sense it is equivavlent to
"foobar" that I guess yo wouldn't have added here :)
Line 72: }
Line 73:
Line 74: public enum ActionType {
Line 75: add,
Line 908: Arguments.domain,
Line 909: Arguments.user,
Line 910: Arguments.passwordFile,
Line 911: Arguments.interactive,
Line 912: Arguments.location);
See comment above regarding location.
Line 913: }
Line 914: } else {
Line 915: throw new
ManageDomainsResult(ManageDomainsResultEnum.ACTION_IS_NOT_SPECIFIED);
Line 916: }
--
To view, visit http://gerrit.ovirt.org/8963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3384c6981d38b03d2f2856ff8af69ac9d1c65056
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
