Oved Ourfali has uploaded a new change for review. Change subject: ui: localizing refresh rate string (#871354) ......................................................................
ui: localizing refresh rate string (#871354) https://bugzilla.redhat.com/871354 The "Refresh Rate" string is not localized. This patch fixes that. Change-Id: I70c5bce38ff49748ee8eccc55f4c490876c422df Signed-off-by: Oved Ourfali <oourf...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/8932/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index a51538d..d768336 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -1043,4 +1043,8 @@ @DefaultStringValue("SPM Priority") String spmPriority(); + + @DefaultStringValue("Refresh Rate") + String refreshRate(); + } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java index 2a1873d..b3931bf 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java @@ -2,10 +2,12 @@ import java.util.Set; +import org.ovirt.engine.ui.common.CommonApplicationConstants; import org.ovirt.engine.ui.common.idhandler.HasElementId; import org.ovirt.engine.ui.common.utils.ElementIdUtils; import org.ovirt.engine.ui.common.widget.renderer.MilisecondRenderer; +import com.google.gwt.core.client.GWT; import com.google.gwt.dom.client.Style; import com.google.gwt.dom.client.Style.BorderStyle; import com.google.gwt.dom.client.Style.Unit; @@ -43,6 +45,8 @@ * Works with an {@link AbstractRefreshManager}. */ public abstract class BaseRefreshPanel extends FocusPanel implements HasClickHandlers, HasElementId { + + private static final CommonApplicationConstants CONSTANTS = GWT.create(CommonApplicationConstants.class); public interface BaseResources extends ClientBundle { @@ -326,7 +330,7 @@ refreshOptionsMenu.setStylePrimaryName(style.refreshRateMenu()); // Create menu's title and add it as the first item - MenuItem title = new MenuItem("Refresh Rate", new Command() { //$NON-NLS-1$ + MenuItem title = new MenuItem(CONSTANTS.refreshRate(), new Command() { @Override public void execute() { } -- To view, visit http://gerrit.ovirt.org/8932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I70c5bce38ff49748ee8eccc55f4c490876c422df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
