Alexander Wels has posted comments on this change. Change subject: webadmin: Support additional hibernate types ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42484/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/hibernate/HibernateCleaner.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/hibernate/HibernateCleaner.java: Line 126: } Line 127: return cleanList; Line 128: } Line 129: Line 130: if (dirty instanceof PersistentIdentifierBag) { > Think there is any way we can combine PersistentList/PersistentIdentifierBa There is, its a PersistentCollection, which defines the wasInitialized. So we can combine the 3 almost identical piece of code into one. Line 131: PersistentIdentifierBag dirtyList = (PersistentIdentifierBag) dirty; Line 132: List<Object> cleanList = new ArrayList<Object>(); Line 133: processed.put(dirtyList, cleanList); Line 134: if (dirtyList.wasInitialized()) { -- To view, visit https://gerrit.ovirt.org/42484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5062b0af221c22ba98c1260c82d95abb88f3435b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
