Daniel Erez has posted comments on this change. Change subject: core: Support restore for Cinder snapshot ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/42339/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java: Line 128: } Line 129: } Line 130: } Line 131: Line 132: if (!cinderDisks.isEmpty() && !restoreAllCinderDisks(cinderDisks, removedSnapshotId)) { this line is repeating itself, maybe we can extract and reuse it? Line 133: log.error("Error deleting unused Cinder volumes to restore snapshots"); Line 134: } Line 135: Line 136: removeSnapshotsFromDB(); Line 129: } Line 130: } Line 131: Line 132: if (!cinderDisks.isEmpty() && !restoreAllCinderDisks(cinderDisks, removedSnapshotId)) { Line 133: log.error("Error deleting unused Cinder volumes to restore snapshots"); is it the relevant log message? (it's the same as line 285..) Line 134: } Line 135: Line 136: removeSnapshotsFromDB(); Line 137: removeUnusedImages(); -- To view, visit https://gerrit.ovirt.org/42339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87e08dd1736b1f49d6fd265d2492ac44b55f0ae4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
