Omer Frenkel has posted comments on this change. Change subject: core: move cached info about last event to vm-manager ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/42469/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 147: Guid vmId = getVmId(pair); Line 148: Line 149: if (vmId != null) { Line 150: VmManager vmManager = getResourceManager().getVmManager(vmId); Line 151: if (vmManager.isLatestData(pair.getSecond(), vdsManager.getVdsId()) && vmManager.trylock()) { it would be safer to take the lock first and then check-and-update the time stamp Line 152: if (fetchTime - vmManager.getVmDataChangedTime() <= 0) { Line 153: log.warn("skipping VM '{}' from this monitoring cycle" + Line 154: " - the VM data has changed since fetching the data", vmId); Line 155: vmManager.unlock(); -- To view, visit https://gerrit.ovirt.org/42469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ee4470d43e3d4690343a0fdc23df2e1fdddbf8e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
