Moti Asayag has posted comments on this change.
Change subject: webadmin: Netwrok as Main Tab- (Phase 3)
......................................................................
Patch Set 4: (5 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-29 17:09:15 +0200
Line 4: Commit: Alona Kaplan <alkap...@redhat.com>
Line 5: CommitDate: 2012-10-29 17:11:00 +0200
Line 6:
Line 7: webadmin: Netwrok as Main Tab- (Phase 3)
s/Netwrok/Network
Line 8:
Line 9: Add to Network->Host subtab radio button that will show either-
Line 10: 1.All the hosts that this network is attached to.
Line 11: 2.All the hosts where this network attached to the cluster but not to
the
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java
Line 18:
Line 19: @SuppressWarnings("unused")
Line 20: public class NetworkClusterListModel extends ClusterListModel
Line 21: {
Line 22: private UICommand privateManageCommand;
s/privateManageCommand/manageCommand
Line 23:
Line 24: public UICommand getManageCommand()
Line 25: {
Line 26: return privateManageCommand;
Line 59: networkManageModel.getCommands().add(0, okCommand);
Line 60:
Line 61: }
Line 62:
Line 63: // private ListModel createNetworkList(List<Network> dcNetworks) {
do we need those commented lines in the code ?
Line 64: // List<ClusterNetworkManageModel> networkList = new
ArrayList<ClusterNetworkManageModel>();
Line 65: // java.util.ArrayList<Network> clusterNetworks =
Linq.<Network> Cast(getItems());
Line 66: // for (Network network : dcNetworks) {
Line 67: // ClusterNetworkManageModel networkManageModel = new
ClusterNetworkManageModel(network);
Line 217: }
Line 218:
Line 219: super.SyncSearch();
Line 220:
Line 221: AsyncQuery _asyncQuery = new AsyncQuery();
s/_asyncQuery/asyncQuery
Line 222: _asyncQuery.setModel(this);
Line 223: _asyncQuery.asyncCallback = new INewAsyncCallback() {
Line 224: @Override
Line 225: public void OnSuccess(Object model, Object ReturnValue)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
Line 60: {
Line 61: return;
Line 62: }
Line 63:
Line 64: AsyncQuery _asyncQuery = new AsyncQuery();
s/_asyncQuery/asyncQuery
Line 65: _asyncQuery.setModel(getViewFilterType());
Line 66: _asyncQuery.asyncCallback = new INewAsyncCallback() {
Line 67: @Override
Line 68: public void OnSuccess(Object model, Object ReturnValue)
--
To view, visit http://gerrit.ovirt.org/8623
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I538a4269315d4c3e005d6e4c0847d9d96d0f469e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
