Omer Frenkel has posted comments on this change. Change subject: core: move vdsm timestamp to VmInternalData ......................................................................
Patch Set 3: (1 comment) minor comment https://gerrit.ovirt.org/#/c/42464/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 200: } Line 201: return vmdynamic; Line 202: } Line 203: Line 204: public static Double getVdsmTimestamp(Map<String, Object> xmlRpcStruct) { not sure about the name, maybe it should be called VdsmCallTimestamp Line 205: if (xmlRpcStruct.containsKey(VdsProperties.statusTime)) { Line 206: return AssignDoubleValue(xmlRpcStruct, VdsProperties.statusTime); Line 207: } Line 208: return -1d; -- To view, visit https://gerrit.ovirt.org/42464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1f37ca4ce4d0af0ff05bc7531074e3adfafa4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
