Maor Lipchuk has uploaded a new change for review.

Change subject: core: Add validation in ImagesHandler method
......................................................................

core: Add validation in ImagesHandler method

Check if number of decendends for image is not empty, if it is return
null.

Change-Id: I6807c2a1f7c9805e7518c0af78bb445f970728d3
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/42473/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
index faa2626..bd68efa 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
@@ -720,6 +720,9 @@
         List<DiskImage> diskSnapshots =
                 
DbFacade.getInstance().getDiskImageDao().getAllSnapshotsForImageGroup(diskId);
         sortImageList(diskSnapshots);
+        if (diskSnapshots.size() < 1) {
+            return null;
+        }
         return diskSnapshots.get(diskSnapshots.size() - 1);
     }
 


-- 
To view, visit https://gerrit.ovirt.org/42473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6807c2a1f7c9805e7518c0af78bb445f970728d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to