Juan Hernandez has posted comments on this change. Change subject: restapi: Vm Icons - REST part ......................................................................
Patch Set 17: Code-Review+1 (3 comments) https://gerrit.ovirt.org/#/c/40655/17/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IconsResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IconsResource.java: Line 13: Line 14: @GET Icons list(); Line 15: Line 16: @Path("{id}") Line 17: public IconResource getVmIconSubResource(@PathParam("id") String id); Consider using the "public" modifier in all or none of the methods. Better to avoid it, as IDEs tend to complain. https://gerrit.ovirt.org/#/c/40655/17/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIconsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIconsResource.java: Line 24: */ Line 25: @Override Line 26: protected Response performRemove(String id) { Line 27: return null; Line 28: } This method isn't needed now, please remove it. Line 29: Line 30: @Override Line 31: protected Icon doPopulate(Icon model, VmIcon entity) { Line 32: return model; https://gerrit.ovirt.org/#/c/40655/17/backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties File backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties: Line 12: DUPLICATE_ACCESS_CONTROL_GLUSTER_VOLUME_REASON=Invalid access control specifications Line 13: DUPLICATE_ACCESS_CONTROL_GLUSTER_VOLUME_DETAIL=Both access_control_list and auth.allow option should have the same value or only one should be present. Line 14: CANNOT_ACTIVATE_UNLESS_MIGRATION_COMPLETED=Brick(s) cannot be activated unless data migration is completed Line 15: GLUSTER_VOLUME_REPLACE_BRICK_NOT_SUPPORTED=Replace brick is not supported. First migrate brick and add new brick instead. Line 16: INVALID_ICON_PARAMETERS=Invalid icon parameters. Either large icon is uploaded using <media_type> and <data> or id of existing icon can be set. Note that these messages will be displayed also when the caller is using JSON. It may be better to avoid XML-like syntax: .. using the "media_type" and "data" attributes or id ... -- To view, visit https://gerrit.ovirt.org/40655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9599565257e1e9d3e6293931fa35a7ad6f5a5f52 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
