Maor Lipchuk has posted comments on this change. Change subject: core: added volume types existence validation ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/41967/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java: Line 23: import org.ovirt.engine.core.compat.Guid; Line 24: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 25: import org.ovirt.engine.core.dao.DiskDao; Line 26: import org.ovirt.engine.core.dao.StorageDomainDAO; Line 27: redundant Line 28: Line 29: public class CinderDisksValidator { Line 30: Line 31: private Iterable<CinderDisk> cinderDisks; Line 186: } Line 187: }); Line 188: } Line 189: Line 190: public ValidationResult validateCinderVolumeTypesExist() { Please add java doc that this is only for single disk Line 191: return validate(new Callable<ValidationResult>() { Line 192: @Override Line 193: public ValidationResult call() { Line 194: final CinderDisk disk = cinderDisks.iterator().next(); -- To view, visit https://gerrit.ovirt.org/41967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781ba3667f4f28db3ab79e2e31346154097ea664 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
