Michael Pasternak has posted comments on this change. Change subject: core, restapi: Convert NFS version to enum ......................................................................
Patch Set 8: (1 inline comment) one comment .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java Line 166: addnetworkBootProtocols(version, BootProtocol.values()); Line 167: addMigrateOnErrorOptions(version, MigrateOnError.values()); Line 168: addStorageFormatOptions(version, StorageFormat.values()); Line 169: addOsTypes(version, OsType.values()); Line 170: addNfsVersions(version, NfsVersion.values()); please make sure it's added to 3.1 version and above Line 171: Line 172: addGlusterTypesAndStates(version); Line 173: Line 174: //Add States. User can't update States, but he still needs to know which exist. -- To view, visit http://gerrit.ovirt.org/8797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d82db7c0ec92135cae8935f013487e97b8f357 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
