Tal Nisan has posted comments on this change. Change subject: webadmin: Size info in GB along side % (2) ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41936/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java: Line 277: }); Line 278: } Line 279: Line 280: private Integer getWarningLowSpaceSize(StorageModel storageModel) { Line 281: if (!storageModel.isNewStorage()) { This null check should be done in line 274 Line 282: Integer percentageValue = warningLowSpaceIndicatorEditor.asValueBox().getValue(); Line 283: return percentageValue == null ? 0 : storageModel.getStorage().getTotalDiskSize() * percentageValue / 100; Line 284: } Line 285: return 0; // This is mot visible, hence meaningless. -- To view, visit https://gerrit.ovirt.org/41936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3c3e0108086ae528cc856d6e4183177ef6d2cb4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
