Martin Peřina has posted comments on this change.

Change subject: improve unlock_entity.sh log message
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42409/1/packaging/setup/dbutils/unlock_entity.sh
File packaging/setup/dbutils/unlock_entity.sh:

Line 73:                                        now(),
Line 74:                                        'USER_RUN_UNLOCK_ENTITY_SCRIPT',
Line 75:                                        2024,
Line 76:                                        10,
Line 77:                                        '${0} :  System user ${user} 
run manually unlock_entity script on entity [type,id] [${object_type},${id}] 
with db user ${DBFUNC_DB_USER}}'
Why do we have two curly brackets at the end of the message? Isn't the one 
enclosing DBFUNC_DB_USER enough?
Line 78:                                )
Line 79:                        "
Line 80:                        echo "unlock ${object_type} ${id} completed 
successfully."
Line 81:                else


-- 
To view, visit https://gerrit.ovirt.org/42409
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44fb5e8e66e2810a38ceae9520ad3dd57a27cfa8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to