Eli Mesika has posted comments on this change. Change subject: core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42403/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java: Line 100: Line 101: @Override Line 102: public void updateAllDiskImageDynamicWithDiskIdByVmId(Collection<Pair<Guid, DiskImageDynamic>> diskImageDynamicForVm) { Line 103: List<Pair<Guid, DiskImageDynamic>> sortedDisks = new ArrayList<>(); Line 104: sortedDisks.addAll(diskImageDynamicForVm); why do we need sortedDisks, IMO we can sort diskImageDynamicForVm isn't it ? Line 105: Collections.sort(sortedDisks, new Comparator<Pair<Guid, DiskImageDynamic>>() { Line 106: Line 107: @Override Line 108: public int compare(Pair<Guid, DiskImageDynamic> o1, Pair<Guid, DiskImageDynamic> o2) { -- To view, visit https://gerrit.ovirt.org/42403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeba728a0a549e845b5355748e15b00d02381256 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
