Piotr Kliczewski has posted comments on this change. Change subject: core: add timestamp for vm-dynamic updates ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/41520/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java: Line 103: * nanoTime should be used as it is more accurate and monotonic, Line 104: * Line 105: * in general this should be called while holding the manager lock Line 106: */ Line 107: public void updateVmDataChangedTime() { I would mark it as final. It is not safe to use non-final methods in ctor. Someone could override it and do something foolish. Line 108: vmDataChangedTime = System.nanoTime(); Line 109: } https://gerrit.ovirt.org/#/c/41520/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 156: // store the locked managers to finally release them at the end of the cycle Line 157: vmManagers.put(vmId, vmManager); Line 158: return true; Line 159: } Line 160: } else { Partially my patch solves an issue with trylock. Whenever we receive an event and the lock is already taken we loose data. Do you think the code will handle using events here? Line 161: log.debug("skipping VM '{}' from this monitoring cycle" + Line 162: " - the VM is locked by its VmManager ", getVmId(pair)); Line 163: } Line 164: } -- To view, visit https://gerrit.ovirt.org/41520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If858993450cf957babdcf337e9b7867a282657bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
