Piotr Kliczewski has posted comments on this change. Change subject: events: use separate queue for events ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/41796/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 182: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Line 183: int connectionTimeOut = Config.<Integer> getValue(ConfigValues.vdsConnectionTimeout) * 1000; Line 184: int heartbeat = Config.<Integer> getValue(ConfigValues.vdsHeartbeatInSeconds) * 1000; Line 185: int clientRetries = Config.<Integer> getValue(ConfigValues.vdsRetries); Line 186: vdsProxy = TransportFactory.createVdsServer( > i wonder why not to pass the VDS as parameter for this method instead of th Passing VDS object could simplify the method but it would introduce more coupling in the code. TransportFactory would need to be aware of this object and its structure. When testing you would need to mock VDS object whereas now you can only provide values you need. Line 187: cachedVds.getProtocol(), Line 188: cachedVds.getVdsGroupCompatibilityVersion(), Line 189: cachedVds.getHostName(), Line 190: cachedVds.getPort(), https://gerrit.ovirt.org/#/c/41796/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 138: private void setProtocol(VdsProtocol value) { Line 139: this.privateProtocol = value; Line 140: } Line 141: Line 142: private Version privateVersion; > the 'private' as prefix for the names is an awkward convention :) It is, I hate it but it is used in this class so need to follow the convention. Line 143: Line 144: private Version getVersion() { Line 145: return this.privateVersion; Line 146: } -- To view, visit https://gerrit.ovirt.org/41796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff65e274d03a8059130fbd9baca1320a6524aa3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
