Sandro Bonazzola has posted comments on this change. Change subject: core: Import the hosted engine VM if its no manged ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/42295/2//COMMIT_MSG Commit Message: Line 24: from now on and to signal the monitoring on when its not imported and Line 25: should be Line 26: Line 27: Change-Id: I0ff2c440785cb91e3beef0530eda77324cc954d0 Line 28: Bug-Url: https://bugzilla.redhat.com/ Please, either drop Bug-url or specify a real bug https://gerrit.ovirt.org/#/c/42295/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 153: image.setShareable(false); Line 154: image.setId(Guid.createGuidFromString((String) deviceMap.get(VdsProperties.DeviceId))); Line 155: image.setImageId(Guid.createGuidFromString((String) deviceMap.get(VdsProperties.VolumeId))); Line 156: // TODO not sure how to extract that info Line 157: image.setVolumeType(VolumeType.Preallocated); Please note that on NFS it's Sparse. Line 158: switch ((String) deviceMap.get("iface")) { Line 159: case "virtio": Line 160: image.setDiskInterface(DiskInterface.VirtIO); Line 161: case "iscsi": -- To view, visit https://gerrit.ovirt.org/42295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ff2c440785cb91e3beef0530eda77324cc954d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
