Maor Lipchuk has posted comments on this change.
Change subject: core: Enable addDisk with a locked disk (#870754)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 183: true,
Line 184: false,
Line 185: false,
Line 186: true,
Line 187: Collections.emptyList());
I think changing null to empty list, might cause skipping on many validation,
for example Images Legality, image exist, and also validation on storage domain
Line 188: }
Line 189:
Line 190: private long getRequestDiskSpace() {
Line 191: if (getParameters().getDiskInfo().getDiskStorageType() ==
DiskStorageType.IMAGE) {
--
To view, visit http://gerrit.ovirt.org/8883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3714b8aa301fd12a2837e00d899b09cc0001f6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
