Tal Nisan has posted comments on this change. Change subject: webadmin: introduce Authentication Keys sub-tab under Providers ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41970/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderSecretListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderSecretListModel.java: Line 171: private void updateActionAvailability() { Line 172: ArrayList<LibvirtSecretModel> secrets = getSelectedItems() != null ? Line 173: Linq.<LibvirtSecretModel> cast(getSelectedItems()) : new ArrayList<LibvirtSecretModel>(); Line 174: Line 175: getEditCommand().setIsExecutionAllowed(secrets.size() > 0); Should it be equals to 1? Or editing of multiple secrets is allowed? Line 176: getRemoveCommand().setIsExecutionAllowed(secrets.size() > 0); Line 177: } Line 178: Line 179: private void cancel() { -- To view, visit https://gerrit.ovirt.org/41970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I477f57edfaa211a6b030269d4c3d52bcb3d5915f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
