Tal Nisan has posted comments on this change. Change subject: webadmin: Tooltip in Disks subtab shows Original Allocation Policy ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41071/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java: Line 253: return null; Line 254: } Line 255: Line 256: VolumeType originalVolumeType = Line 257: diskImage.getSnapshots().get(diskImage.getSnapshots().size() - 1).getVolumeType(); Discussed offline, please check that the snapshot order you rely on in this logic is always as you expect or better, just look for the parent image Line 258: return SafeHtmlUtils.fromString( Line 259: StringFormat.format("%s: %s", //$NON-NLS-1$ Line 260: AssetProvider.getConstants().originalAllocationDisk(), Line 261: EnumTranslator.getInstance().translate(originalVolumeType))); -- To view, visit https://gerrit.ovirt.org/41071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I267eb950c57f4c5cca92d5fdd04e1294b1b2f2b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
