anmolbabu has posted comments on this change.

Change subject: engine: Pass username to geo-rep config list
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/42321/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java:

Line 441:         }
Line 442:         try {
Line 443:             VDSReturnValue returnValue = 
runVdsCommand(VDSCommandType.GetGlusterVolumeGeoRepConfigList,
Line 444:                     new 
GlusterVolumeGeoRepSessionVDSParameters(upServer.getId(),
Line 445:                             session.getMasterVolumeName(), 
session.getSlaveHostName(), session.getSlaveVolumeName(), 
session.getUserName()));
> please use formatter. line is too long.
Done
Line 446:             if (returnValue.getSucceeded()) {
Line 447:                 return (List<GlusterGeoRepSessionConfiguration>) 
returnValue.getReturnValue();
Line 448:             } else {
Line 449:                 log.error("VDS error {}", 
returnValue.getVdsError().getMessage());


-- 
To view, visit https://gerrit.ovirt.org/42321
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9bb464d152eec066a8c160a6691c758b5516ceb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to