Omer Frenkel has posted comments on this change. Change subject: core: SPICE copyPaste/fileTransfer not passed properly ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42038/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 148: } Line 149: createInfo.put(VdsProperties.transparent_huge_pages, Line 150: vm.isTransparentHugePages() ? "true" : "false"); Line 151: Line 152: List<VmDevice> spiceDevs = DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmIdTypeAndDevice( i think this will break run once it seems the right fix would be that runVmCommand will always send the graphic info, run-once already send the right info, need to do the same in regular run as well. what do you think? Line 153: vm.getId(), Line 154: VmDeviceGeneralType.GRAPHICS, Line 155: VmDeviceType.SPICE.getName() Line 156: ); -- To view, visit https://gerrit.ovirt.org/42038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic09709b579fd3e2fe622790f66286537ad01e728 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
