Moti Asayag has posted comments on this change. Change subject: core[BLL]: Adding external status to command ......................................................................
Patch Set 6: Code-Review+2 (1 comment) tiny comment which can be fixed later https://gerrit.ovirt.org/#/c/42135/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java: Line 21: private static final String OVIRT="oVirt"; Line 22: Line 23: @Inject VdsDynamicDAO hostDao; Line 24: Line 25: @Inject StorageDomainDynamicDAO storageDomainDynamicDAO; name should be in camelCase: storageDomainDynamicDao Line 26: Line 27: public AddExternalEventCommand(T parameters) { Line 28: super(parameters); Line 29: } -- To view, visit https://gerrit.ovirt.org/42135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8e3c0f6f54336d8ac1a621e69cd22cb79da80 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
