Daniel Erez has uploaded a new change for review. Change subject: core: CloneCinderDisks - handle command statuses ......................................................................
core: CloneCinderDisks - handle command statuses * Handle NOT_STARTED and SUCCEEDED command statuses on CloneCinderDisksCommandCallback. * Set parent command and parameters in CloneCinderDisksCommand. Change-Id: I6f4adecd6289920581857c444d89684f91ed4ae2 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/42315/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java index e67a279..a843a96 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java @@ -69,7 +69,9 @@ cinderDisk.setDiskAlias(templateDisk.getDiskAlias()); createParams.setStorageDomainId(templateDisk.getStorageIds().get(0)); createParams.setEntityInfo(getParameters().getEntityInfo()); - return withRootCommandInfo(createParams, getParameters().getParentCommand()); + createParams.setParentCommand(getActionType()); + createParams.setParentParameters(getParameters()); + return createParams; } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java index f4ae66c..516b964 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java @@ -20,9 +20,12 @@ for (Guid childCmdId : childCmdIds) { CommandStatus commandStatus = CommandCoordinatorUtil.getCommandStatus(childCmdId); switch (commandStatus) { + case NOT_STARTED: case ACTIVE: log.info("Waiting on CloneCinderDisksCommandCallback child commands to complete"); return; + case SUCCEEDED: + break; case FAILED: case FAILED_RESTARTED: case UNKNOWN: -- To view, visit https://gerrit.ovirt.org/42315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6f4adecd6289920581857c444d89684f91ed4ae2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
