Maor Lipchuk has posted comments on this change. Change subject: core: Introduce TryBackToCinderSnapshotCommand. ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/42062/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToCinderSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToCinderSnapshotCommand.java: Line 76: * @param active Line 77: * The active state. Line 78: */ Line 79: protected void updateOldImageAsActive(Snapshot.SnapshotType snapshotType, boolean active) { Line 80: Guid oldImageId = findImageForSameDrive(snapshotType); > no change? merge issues, done now Line 81: if (oldImageId == null) { Line 82: log.error("Can't find image to update to active '{}', snapshot type '{}', original image id '{}'", Line 83: active, Line 84: snapshotType, -- To view, visit https://gerrit.ovirt.org/42062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532fed7fe11a033c8b86251e5ad8b73230801c2d Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
