Eliraz Levi has posted comments on this change. Change subject: backend: engine resolving host's active interface ......................................................................
Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/35895/10/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java: Line 289: vds > s/vds/host Done Line 294: Fail > s/Fail/Failed Done https://gerrit.ovirt.org/#/c/35895/10/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1552: vds > s/vds/host Done Line 1620: // the interface will have the host's engine IP Line 1621: final VdsNetworkInterface activeIface = resolveActiveNic(vds, hostIp); Line 1622: String hostActiveNic = (activeIface == null) ? null : activeIface.getName(); Line 1623: Line 1624: final String activeBridge = findActiveBridge(hostIp, bridges); > why not to reverse the order of the conditions by their importance ? Done Line 1625: if (activeBridge != null) { Line 1626: hostActiveNic = activeBridge; Line 1627: } Line 1628: return hostActiveNic; -- To view, visit https://gerrit.ovirt.org/35895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64a21595e58358fe9e04ea1de5d3e3115c7bc2c6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
