Maor Lipchuk has posted comments on this change. Change subject: core: delete Cinder volumes should be surrounded by try catch. ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42252/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-06-12 05:55:12 +0300 Line 6: Line 7: core: delete Cinder volumes should be surrounded by try catch. Line 8: Line 9: Delete of volume and snapshot from CinderBroker should return a > Are you using the return value or is it just for future usage? There is no reason to throw an exception if we want to remove a disk which does not exists. The boolean is for future use, currently we will simply continue with the flow and see later in the callback command that the volume is not exists Line 10: notification whether it succeeded or not, and should be surrounded with Line 11: try catch block to prevent exception when the volume does not exists. Line 12: Line 13: Change-Id: I01811c092f72d8f5409866f308ea7b3c5cfb3ff0 -- To view, visit https://gerrit.ovirt.org/42252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01811c092f72d8f5409866f308ea7b3c5cfb3ff0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
