Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Mount the gluster meta volume on the nodes ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/40688/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java: Line 295: doNothing().when(glusterManager).mountMetaVolumeOnNodes(any(Guid.class)); > You can also verify that mountMetaVolumeOnNodes() is called for the meta vo Actually meta volume name is utilized at VDSM command layer, so I just mocked here only. https://gerrit.ovirt.org/#/c/40688/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1956: metaVolumeMount > metaVolumeName? Good catch. It works as its passed for a wrong parameter and VDSM defaults it to correct meta volume name in the verb :) Will correct anyway. -- To view, visit https://gerrit.ovirt.org/40688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74199eac5c1b7f0f8bec8ad78b2f417a8fc5960a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
