Daniel Erez has posted comments on this change. Change subject: core: Support preview for Cinder snapshot ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/42256/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java: Line 125: protected In which sub-class are you using it? Line 217: CINDER_ERROR you should add some informative message.. Line 234: returnValue Are you setting it to false in any flow? Line 285: IMAGE worth having some generic method for checking 'IMAGE || CINDER'.. maybe even in DiskStorageType? or isSnappableStorageType somewhere? :) -- To view, visit https://gerrit.ovirt.org/42256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c7f7a9505ff965b0cded35c395e5bfb8529aaa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
