Alexander Wels has posted comments on this change. Change subject: webadmin: clicking system tree doesn't update main tab ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42238/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java: Line 265: autoSelectFirst(); Line 266: } Line 267: Line 268: @Override Line 269: public void setVisible(boolean visible) { > Maybe a silly question, but why do we need to override UIObject#setVisible Not a silly question at all, it solves the following scenario. 1. I go to a tab with a single item, this is solved with the onLoad. 2. I go to another tab which hides (doesn't detach it) the tab. 3. I come back, the tab is attached but not hidden, so now it becomes visible and I still need to make sure the item is auto selected, the onLoad won't be called because its already attached. Line 270: super.setVisible(visible); Line 271: if (visible && isAttached()) { Line 272: autoSelectFirst(); Line 273: } -- To view, visit https://gerrit.ovirt.org/42238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ee1171f16ec239332c981bf28f7d5c9fa690edc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
